-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[amlfs] Add az amlfs import/az amlfs auto-export commands #8851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amlfs] Add az amlfs import/az amlfs auto-export commands #8851
Conversation
…ort extension commandlets
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| amlfs auto-export | sub group amlfs auto-export added |
||
| amlfs import | sub group amlfs import added |
||
| amlfs list | cmd amlfs list added parameter pagination_limit |
||
| amlfs list | cmd amlfs list added parameter pagination_token |
|
Hi @Aman-Jain-14, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new CLI commands for managing AML filesystem import and auto-export jobs and updates existing AMLFS commands for consistency.
- Add
amlfs importcommand group with show, list, and delete operations. - Add
amlfs auto-exportcommand group with create, update, list, show, delete, and wait operations. - Update existing AMLFS core command definitions (identity schema type, pagination support, and command group description).
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File/Path | Description |
|---|---|
| src/amlfs/azext_amlfs/aaz/latest/amlfs/import/ | Added amlfs import subcommands (show, list, delete) |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/import/init.py | Registered import subcommands |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/import/__cmd_group.py | Defined amlfs import command group |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/ | Added amlfs auto-export commands (create, update, list, show, delete) |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/init.py | Registered auto-export subcommands |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/__cmd_group.py | Defined amlfs auto-export command group |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/_wait.py | Switched identity schema to AAZIdentityObjectType |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/_update.py | Switched identity schema to AAZIdentityObjectType |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/_show.py | Switched identity schema to AAZIdentityObjectType |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/_list.py | Enabled pagination; switched identity schema type |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/_create.py | Switched identity builder to AAZIdentityObjectType; schema updates |
| src/amlfs/azext_amlfs/aaz/latest/amlfs/__cmd_group.py | Updated root command group docstring to a more generic description |
| src/amlfs/azext_amlfs/aaz/latest/init.py | Added flake8/pylint directives |
Comments suppressed due to low confidence (3)
src/amlfs/azext_amlfs/aaz/latest/amlfs/__cmd_group.py:18
- [nitpick] The root command group docstring is very generic. Consider updating it to something more descriptive, e.g., 'Manage Azure Machine Learning File System resources.'
"""This is an extension to Azure CLI to manage Amlfs resources.
src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/_update.py:20
- The example tag and the subsequent example command reference an incorrect command name. Update the example to reflect the actual command (
az amlfs auto-export update).
:example: autoExportJobs_CreateOrUpdate
src/amlfs/azext_amlfs/aaz/latest/amlfs/import/init.py:16
- The module imports
_updateand_waitwhich are not present in this directory. Either add the missing command files (_create.py,_update.py,_wait.py) or remove these imports to prevent import errors.
from ._update import *
|
|
@evelyn-ys @yonzhan @calvinhzy |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ amlfs-1.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127029531&view=results |
[StorageCache] BREAKING CHANGE: Add az amlfs import/az amlfs auto-export commands
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az amlfs import create/update/list/show/delete
az amlfs auto-export create/update/list/show/delete
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.