Skip to content

Conversation

@Aman-Jain-14
Copy link
Member

[StorageCache] BREAKING CHANGE: Add az amlfs import/az amlfs auto-export commands


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az amlfs import create/update/list/show/delete
az amlfs auto-export create/update/list/show/delete

General Guidelines

  • [YES] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [YES] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [YES] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 10, 2025 14:06
@Aman-Jain-14 Aman-Jain-14 requested a review from jsntcy as a code owner June 10, 2025 14:06
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 10, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️amlfs
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd amlfs auto-export sub group amlfs auto-export added
⚠️ 1011 - SubgroupAdd amlfs import sub group amlfs import added
⚠️ 1006 - ParaAdd amlfs list cmd amlfs list added parameter pagination_limit
⚠️ 1006 - ParaAdd amlfs list cmd amlfs list added parameter pagination_token

@azure-client-tools-bot-prd
Copy link

Hi @Aman-Jain-14,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 10, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new CLI commands for managing AML filesystem import and auto-export jobs and updates existing AMLFS commands for consistency.

  • Add amlfs import command group with show, list, and delete operations.
  • Add amlfs auto-export command group with create, update, list, show, delete, and wait operations.
  • Update existing AMLFS core command definitions (identity schema type, pagination support, and command group description).

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File/Path Description
src/amlfs/azext_amlfs/aaz/latest/amlfs/import/ Added amlfs import subcommands (show, list, delete)
src/amlfs/azext_amlfs/aaz/latest/amlfs/import/init.py Registered import subcommands
src/amlfs/azext_amlfs/aaz/latest/amlfs/import/__cmd_group.py Defined amlfs import command group
src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/ Added amlfs auto-export commands (create, update, list, show, delete)
src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/init.py Registered auto-export subcommands
src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/__cmd_group.py Defined amlfs auto-export command group
src/amlfs/azext_amlfs/aaz/latest/amlfs/_wait.py Switched identity schema to AAZIdentityObjectType
src/amlfs/azext_amlfs/aaz/latest/amlfs/_update.py Switched identity schema to AAZIdentityObjectType
src/amlfs/azext_amlfs/aaz/latest/amlfs/_show.py Switched identity schema to AAZIdentityObjectType
src/amlfs/azext_amlfs/aaz/latest/amlfs/_list.py Enabled pagination; switched identity schema type
src/amlfs/azext_amlfs/aaz/latest/amlfs/_create.py Switched identity builder to AAZIdentityObjectType; schema updates
src/amlfs/azext_amlfs/aaz/latest/amlfs/__cmd_group.py Updated root command group docstring to a more generic description
src/amlfs/azext_amlfs/aaz/latest/init.py Added flake8/pylint directives
Comments suppressed due to low confidence (3)

src/amlfs/azext_amlfs/aaz/latest/amlfs/__cmd_group.py:18

  • [nitpick] The root command group docstring is very generic. Consider updating it to something more descriptive, e.g., 'Manage Azure Machine Learning File System resources.'
"""This is an extension to Azure CLI to manage Amlfs resources.

src/amlfs/azext_amlfs/aaz/latest/amlfs/auto_export/_update.py:20

  • The example tag and the subsequent example command reference an incorrect command name. Update the example to reflect the actual command (az amlfs auto-export update).
:example: autoExportJobs_CreateOrUpdate

src/amlfs/azext_amlfs/aaz/latest/amlfs/import/init.py:16

  • The module imports _update and _wait which are not present in this directory. Either add the missing command files (_create.py, _update.py, _wait.py) or remove these imports to prevent import errors.
from ._update import *

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

@Aman-Jain-14
Copy link
Member Author

@evelyn-ys @yonzhan @calvinhzy
Can we please get this reviewed? This version of our extension has important feature support that is an urgent customer ask.

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys evelyn-ys changed the title [StorageCache] BREAKING CHANGE: Add az amlfs import/az amlfs auto-export commands [amlfs] BREAKING CHANGE: Add az amlfs import/az amlfs auto-export commands Jun 12, 2025
@evelyn-ys evelyn-ys changed the title [amlfs] BREAKING CHANGE: Add az amlfs import/az amlfs auto-export commands [amlfs] Add az amlfs import/az amlfs auto-export commands Jun 12, 2025
@evelyn-ys evelyn-ys merged commit d680a0d into Azure:main Jun 12, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ amlfs-1.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127029531&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants